Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stream/List of Events for incompleteEventPublications #581

Open
zikozee opened this issue May 5, 2024 · 2 comments
Open

Expose stream/List of Events for incompleteEventPublications #581

zikozee opened this issue May 5, 2024 · 2 comments

Comments

@zikozee
Copy link

zikozee commented May 5, 2024

I am looking at a scenario where I can dynamically batch the incomplete events which can also give room to do some extra work before or after.

@patrzalektom
Copy link

patrzalektom commented May 21, 2024

@odrotbohm - the thing mentioned here is that CompletedEventPublications interface exposes a method findAll() which would return all completed event publications, but IncompleteEventPublications does not provide such a method and there's a need to inject EventPublicationRegistry (e.g. in tests) to assert anything related to incomplete publications.

This difference might be misleading in my opinion.

I could try handling this and opening a pull request with that, what do you think about that?

patrzalektom pushed a commit to patrzalektom/spring-modulith that referenced this issue May 22, 2024
@patrzalektom
Copy link

Mentioned pull request: #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants