[WIP] PR: Update icons using a threadpool in File Explorer #10337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dalthviz remember to test this issue by commenting all the |
|
@goanpeca it can freeze even without the IconProvider (although just for some seconds and I have to do the scrolling quite quickly):
|
|
@dalthviz, do these freezes happen in Spyder 3? |
|
@ccordoba12 Spyder 3 can freeze, although just when adding/deleting a lot of files from the directory you are viewing:
|
dalthviz
force-pushed
the
fixes_issue_10081
branch
from
c827f3c to
e46b04e
Compare
|
Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Closing because this solution doesn't really solve the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Change the way we set file icons to prevent GUI freezing
Issue(s) Resolved
Fixes #10081
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz