Skip to content

Commit

Permalink
tests: make regression tests use squash rule
Browse files Browse the repository at this point in the history
Signed-off-by: Miguel Molina <[email protected]>
  • Loading branch information
erizocosmico committed Jun 11, 2019
1 parent 50061f6 commit 8363cd4
Showing 1 changed file with 17 additions and 15 deletions.
32 changes: 17 additions & 15 deletions regression_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"testing"

"github.com/src-d/gitbase"
"github.com/stretchr/testify/require"
"github.com/src-d/go-mysql-server/sql"
"github.com/src-d/go-mysql-server/sql/index/pilosa"
"github.com/stretchr/testify/require"
yaml "gopkg.in/yaml.v2"
)

Expand All @@ -20,13 +20,12 @@ type Query struct {
}

func TestRegressionQueries(t *testing.T) {
require := require.New(t)

engine, pool, cleanup := setup(t)
_, pool, cleanup := setup(t)
defer cleanup()

engine := newSquashEngine(pool)
tmpDir, err := ioutil.TempDir(os.TempDir(), "pilosa-idx-gitbase")
require.NoError(err)
require.NoError(t, err)
defer os.RemoveAll(tmpDir)
engine.Catalog.RegisterIndexDriver(pilosa.NewDriver(tmpDir))

Expand All @@ -36,20 +35,23 @@ func TestRegressionQueries(t *testing.T) {
)

queries, err := loadQueriesYaml("./_testdata/regression.yml")
require.NoError(err)
require.NoError(t, err)

for _, q := range queries {
for _, stmt := range q.Statements {
_, iter, err := engine.Query(ctx, stmt)
if err != nil {
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
}
t.Run(q.ID, func(t *testing.T) {
require := require.New(t)
for _, stmt := range q.Statements {
_, iter, err := engine.Query(ctx, stmt)
if err != nil {
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
}

_, err = sql.RowIterToRows(iter)
if err != nil {
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
_, err = sql.RowIterToRows(iter)
if err != nil {
require.Failf(err.Error(), "ID: %s, Name: %s, Statement: %s", q.ID, q.Name, stmt)
}
}
}
})
}
}

Expand Down

0 comments on commit 8363cd4

Please sign in to comment.