Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 884b6a1

Browse files
committedNov 27, 2024··
Bump ruby-lsp support to 0.22.0
1 parent 0da0abf commit 884b6a1

18 files changed

+4518
-3156
lines changed
 

‎Gemfile.lock

+24-22
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ PATH
22
remote: .
33
specs:
44
ruby-lsp-rspec (0.1.18)
5-
ruby-lsp (~> 0.21.0)
5+
ruby-lsp (~> 0.22.0)
66

77
GEM
88
remote: https://rubygems.org/
@@ -17,16 +17,16 @@ GEM
1717
irb (1.14.1)
1818
rdoc (>= 4.0.0)
1919
reline (>= 0.4.2)
20-
json (2.7.5)
20+
json (2.8.2)
2121
language_server-protocol (3.17.0.3)
2222
logger (1.6.1)
2323
netrc (0.11.0)
2424
parallel (1.26.3)
25-
parser (3.3.5.1)
25+
parser (3.3.6.0)
2626
ast (~> 2.4.1)
2727
racc
2828
prism (1.2.0)
29-
psych (5.1.2)
29+
psych (5.2.0)
3030
stringio
3131
racc (1.8.1)
3232
rainbow (3.1.1)
@@ -36,10 +36,10 @@ GEM
3636
sorbet-runtime (>= 0.5.9204)
3737
rbs (3.6.1)
3838
logger
39-
rdoc (6.7.0)
39+
rdoc (6.8.1)
4040
psych (>= 4.0.0)
4141
regexp_parser (2.9.2)
42-
reline (0.5.10)
42+
reline (0.5.11)
4343
io-console (~> 0.5)
4444
rspec (3.13.0)
4545
rspec-core (~> 3.13.0)
@@ -54,45 +54,45 @@ GEM
5454
diff-lcs (>= 1.2.0, < 2.0)
5555
rspec-support (~> 3.13.0)
5656
rspec-support (3.13.1)
57-
rubocop (1.68.0)
57+
rubocop (1.69.0)
5858
json (~> 2.3)
5959
language_server-protocol (>= 3.17.0)
6060
parallel (~> 1.10)
6161
parser (>= 3.3.0.2)
6262
rainbow (>= 2.2.2, < 4.0)
6363
regexp_parser (>= 2.4, < 3.0)
64-
rubocop-ast (>= 1.32.2, < 2.0)
64+
rubocop-ast (>= 1.36.1, < 2.0)
6565
ruby-progressbar (~> 1.7)
66-
unicode-display_width (>= 2.4.0, < 3.0)
67-
rubocop-ast (1.33.0)
66+
unicode-display_width (>= 2.4.0, < 4.0)
67+
rubocop-ast (1.36.2)
6868
parser (>= 3.3.1.0)
6969
rubocop-rake (0.6.0)
7070
rubocop (~> 1.0)
7171
rubocop-shopify (2.15.1)
7272
rubocop (~> 1.51)
7373
rubocop-sorbet (0.8.7)
7474
rubocop (>= 1)
75-
ruby-lsp (0.21.2)
75+
ruby-lsp (0.22.1)
7676
language_server-protocol (~> 3.17.0)
7777
prism (>= 1.2, < 2.0)
7878
rbs (>= 3, < 4)
7979
sorbet-runtime (>= 0.5.10782)
8080
ruby-progressbar (1.13.0)
81-
sorbet (0.5.11633)
82-
sorbet-static (= 0.5.11633)
83-
sorbet-runtime (0.5.11633)
84-
sorbet-static (0.5.11633-universal-darwin)
85-
sorbet-static (0.5.11633-x86_64-linux)
86-
sorbet-static-and-runtime (0.5.11633)
87-
sorbet (= 0.5.11633)
88-
sorbet-runtime (= 0.5.11633)
81+
sorbet (0.5.11670)
82+
sorbet-static (= 0.5.11670)
83+
sorbet-runtime (0.5.11670)
84+
sorbet-static (0.5.11670-universal-darwin)
85+
sorbet-static (0.5.11670-x86_64-linux)
86+
sorbet-static-and-runtime (0.5.11670)
87+
sorbet (= 0.5.11670)
88+
sorbet-runtime (= 0.5.11670)
8989
spoom (1.5.0)
9090
erubi (>= 1.10.0)
9191
prism (>= 0.28.0)
9292
sorbet-static-and-runtime (>= 0.5.10187)
9393
thor (>= 0.19.2)
94-
stringio (3.1.1)
95-
tapioca (0.16.3)
94+
stringio (3.1.2)
95+
tapioca (0.16.5)
9696
bundler (>= 2.2.25)
9797
netrc (>= 0.11.0)
9898
parallel (>= 1.21.0)
@@ -102,7 +102,9 @@ GEM
102102
thor (>= 1.2.0)
103103
yard-sorbet
104104
thor (1.3.2)
105-
unicode-display_width (2.6.0)
105+
unicode-display_width (3.1.2)
106+
unicode-emoji (~> 4.0, >= 4.0.4)
107+
unicode-emoji (4.0.4)
106108
yard (0.9.37)
107109
yard-sorbet (0.9.0)
108110
sorbet-runtime

‎lib/ruby_lsp/ruby_lsp_rspec/addon.rb

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ class Addon < ::RubyLsp::Addon
1717
sig { override.params(global_state: GlobalState, message_queue: Thread::Queue).void }
1818
def activate(global_state, message_queue)
1919
@index = T.let(global_state.index, T.nilable(RubyIndexer::Index))
20-
global_state.index.register_enhancement(IndexingEnhancement.new(global_state.index))
2120
end
2221

2322
sig { override.void }

‎lib/ruby_lsp/ruby_lsp_rspec/indexing_enhancement.rb

+4-32
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,8 @@ module RSpec
66
class IndexingEnhancement < RubyIndexer::Enhancement
77
extend T::Sig
88

9-
sig do
10-
override.params(
11-
owner: T.nilable(RubyIndexer::Entry::Namespace),
12-
node: Prism::CallNode,
13-
file_path: String,
14-
code_units_cache: T.any(
15-
T.proc.params(arg0: Integer).returns(Integer),
16-
Prism::CodeUnitsCache,
17-
),
18-
).void
19-
end
20-
def on_call_node_enter(owner, node, file_path, code_units_cache)
9+
sig { override.params(node: Prism::CallNode).void }
10+
def on_call_node_enter(node)
2111
return if node.receiver
2212

2313
name = node.name
@@ -43,16 +33,7 @@ def on_call_node_enter(owner, node, file_path, code_units_cache)
4333

4434
return unless method_name
4535

46-
@index.add(RubyIndexer::Entry::Method.new(
47-
method_name,
48-
file_path,
49-
RubyIndexer::Location.from_prism_location(block_node.location, code_units_cache),
50-
RubyIndexer::Location.from_prism_location(block_node.location, code_units_cache),
51-
nil,
52-
[RubyIndexer::Entry::Signature.new([])],
53-
RubyIndexer::Entry::Visibility::PUBLIC,
54-
owner,
55-
))
36+
@listener.add_method(method_name, block_node.location, [RubyIndexer::Entry::Signature.new([])])
5637
when :subject, :subject!
5738
block_node = node.block
5839
return unless block_node
@@ -76,16 +57,7 @@ def on_call_node_enter(owner, node, file_path, code_units_cache)
7657

7758
return unless method_name
7859

79-
@index.add(RubyIndexer::Entry::Method.new(
80-
method_name,
81-
file_path,
82-
RubyIndexer::Location.from_prism_location(block_node.location, code_units_cache),
83-
RubyIndexer::Location.from_prism_location(block_node.location, code_units_cache),
84-
nil,
85-
[RubyIndexer::Entry::Signature.new([])],
86-
RubyIndexer::Entry::Visibility::PUBLIC,
87-
owner,
88-
))
60+
@listener.add_method(method_name, block_node.location, [RubyIndexer::Entry::Signature.new([])])
8961
end
9062
end
9163
end

‎ruby-lsp-rspec.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,5 @@ Gem::Specification.new do |spec|
4141
spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
4242
spec.require_paths = ["lib"]
4343

44-
spec.add_dependency "ruby-lsp", "~> 0.21.0"
44+
spec.add_dependency "ruby-lsp", "~> 0.22.0"
4545
end

‎sorbet/rbi/gems/json@2.7.5.rbi ‎sorbet/rbi/gems/json@2.8.2.rbi

+405-133
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

‎sorbet/rbi/gems/psych@5.1.2.rbi ‎sorbet/rbi/gems/psych@5.2.0.rbi

+287-234
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/rdoc@6.7.0.rbi ‎sorbet/rbi/gems/rdoc@6.8.1.rbi

+948-953
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/rubocop-ast@1.33.0.rbi ‎sorbet/rbi/gems/rubocop-ast@1.36.2.rbi

+410-315
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/rubocop@1.68.0.rbi ‎sorbet/rbi/gems/rubocop@1.69.0.rbi

+1,588-1,042
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/ruby-lsp@0.21.2.rbi ‎sorbet/rbi/gems/ruby-lsp@0.22.1.rbi

+366-261
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

‎sorbet/rbi/gems/tapioca@0.16.3.rbi ‎sorbet/rbi/gems/tapioca@0.16.5.rbi

+102-88
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/unicode-display_width@2.6.0.rbi

-66
This file was deleted.

‎sorbet/rbi/gems/unicode-display_width@3.1.2.rbi

+130
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/gems/unicode-emoji@4.0.4.rbi

+251
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sorbet/rbi/shims/ruby_lsp.rbi

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
module RubyIndexer
55
class Enhancement
66
# If we change ruby-lsp to use a `T.let` then this can be removed
7-
def initialize(index)
8-
@index = T.let(index, RubyIndexer::Index)
7+
def initialize(listener)
8+
@listener = T.let(listener, DeclarationListener)
99
end
1010
end
1111
end

‎spec/definition_spec.rb

-6
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
uri = URI(tempfile.path)
2626

2727
with_server(source, uri) do |server, uri|
28-
index = server.instance_variable_get(:@global_state).index
29-
index.index_single(RubyIndexer::IndexablePath.new(nil, tempfile.path))
3028
server.process_message(
3129
{
3230
id: 1,
@@ -93,8 +91,6 @@
9391
uri = URI(tempfile.path)
9492

9593
with_server(source, uri) do |server, uri|
96-
index = server.instance_variable_get(:@global_state).index
97-
index.index_single(RubyIndexer::IndexablePath.new(nil, tempfile.path))
9894
server.process_message(
9995
{
10096
id: 1,
@@ -154,8 +150,6 @@
154150
uri = URI(tempfile.path)
155151

156152
with_server(source, uri) do |server, uri|
157-
index = server.instance_variable_get(:@global_state).index
158-
index.index_single(RubyIndexer::IndexablePath.new(nil, tempfile.path))
159153
server.process_message(
160154
{
161155
id: 1,

0 commit comments

Comments
 (0)
Please sign in to comment.