Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize PR publish message to be more concise #189

Open
zyyv opened this issue Aug 22, 2024 · 4 comments
Open

Optimize PR publish message to be more concise #189

zyyv opened this issue Aug 22, 2024 · 4 comments

Comments

@zyyv
Copy link
Contributor

zyyv commented Aug 22, 2024

I noticed that when the number of packages exceeds 4, the publish message will be merged into the details tag, but when the length is too long, it still affects the reading (this is a bad case). I hope to make some improvements, such as this

I'm willing to send a PR for optimize it.


commit: e3edcf5

List of Packages (Name to be determined)
  • @packages/a

    pnpm add https://pkg.pr.new/@packages/a@0001
    

  • @packages/b

    pnpm add https://pkg.pr.new/@packages/b@0002
    

  • @packages/c

    pnpm add https://pkg.pr.new/@packages/c@0003
    

  • @packages/d

    pnpm add https://pkg.pr.new/@packages/d@0004
    

  • etc.

    pnpm add https://pkg.pr.new/@...
    

@Aslemammad
Copy link
Member

I see, let's see what @patak-dev thinks of this.

@patak-dev
Copy link
Collaborator

Ya, that is taking too much vertical space. Maybe if there are more than 4 packages, there should be a single collapsed "Package previews" list and inside it you get all packages without <details>, just a flat list like when there are 1-4 packages.

A later improvement could be that projects can define a short list of main packages so even if there are more than 4, you still get the main ones visible with out an extra click. For UnoCSS, it could be:

pnpm add https://pkg.pr.new/unocss@4083
Other Packages...

@zyyv
Copy link
Contributor Author

zyyv commented Aug 22, 2024

Ya, that is taking too much vertical space. Maybe if there are more than 4 packages, there should be a single collapsed "Package previews" list and inside it you get all packages without <details>, just a flat list like when there are 1-4 packages.

A later improvement could be that projects can define a short list of main packages so even if there are more than 4, you still get the main ones visible with out an extra click. For UnoCSS, it could be:

pnpm add https://pkg.pr.new/unocss@4083

Other Packages...

I understand what you mean, do you want to control the main packages through options, or the natural order of packages?

@patak-dev
Copy link
Collaborator

I mean adding a new option, I don't think this can be inferred. But good to just hide everything under a flat list for now too I guess, that should be supported as the default anyways even if the option is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants