Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Decoupling Copilot Provider from HTTPS proxy #384

Closed
lukehinds opened this issue Dec 16, 2024 · 5 comments
Closed

Design Decoupling Copilot Provider from HTTPS proxy #384

lukehinds opened this issue Dec 16, 2024 · 5 comments
Assignees

Comments

@lukehinds
Copy link
Contributor

With clients such as Cursor, windsurf and others also leveraging a HTTPS proxy like copilot, I fully expect there might be boilerplate we can extract from copilot and make available to multiple providers

@lukehinds
Copy link
Contributor Author

#439 related

@jhrozek jhrozek changed the title Extract reusable generics from GitHub Provider Extract reusable generics from Copilot Provider Jan 14, 2025
@jhrozek
Copy link
Contributor

jhrozek commented Jan 14, 2025

We started thinking about this with @ptelang given that this is a prereq to the Cursor work and in general will make our life easier.

OK to move to ready/in progress @lukehinds ?

@jhrozek
Copy link
Contributor

jhrozek commented Jan 16, 2025

@lukehinds lukehinds changed the title Extract reusable generics from Copilot Provider Decouple Copilot Provider from HTTPS proxy Jan 16, 2025
@jhrozek
Copy link
Contributor

jhrozek commented Jan 17, 2025

@lukehinds @ptelang before we start the refactoring I spent today getting the http requests in shape to handle streamed requests which cursor uses for sending protobufs through http. I'm not done yet, but so far it seems promising. The idea is to first just get to a state where we can gather the whole streamed request, unpack it and then say "oh this is protobuf" and send it to target. The next step will be checking and unpacking the protobuf body.

@jhrozek
Copy link
Contributor

jhrozek commented Jan 20, 2025

The design was done and I split the implementation part into #659. This is because we took a detour to see if cursor support is something we can feasibly do at all. I will close this issue now.

@jhrozek jhrozek changed the title Decouple Copilot Provider from HTTPS proxy Design Decoupling Copilot Provider from HTTPS proxy Jan 20, 2025
@jhrozek jhrozek closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants