Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use a testing authority #458

Open
mvandeberg opened this issue Oct 28, 2019 · 0 comments
Open

Update tests to use a testing authority #458

mvandeberg opened this issue Oct 28, 2019 · 0 comments

Comments

@mvandeberg
Copy link
Contributor

All steem-js tests use a key that is valid on the MainNet. This means that all transactions used for testing are actually valid transactions. Thankfully, these are only transactions that require a posting auth.

These tests should be changed to use an authority not on the MainNet (blocked by steemit/steem#3546)

Furthermore, there are some tests that require active auths that do not work. These can be updated and pass safely without providing active keys in the repo.
@mvandeberg mvandeberg changed the title Update Active Auth tests to use a testing authority Update tests to use a testing authority Oct 28, 2019
@mvandeberg mvandeberg mentioned this issue Oct 28, 2019
Merged
mvandeberg added a commit that referenced this issue Oct 31, 2019
@mvandeberg
Fix active auth tests to use a testing authority #458
c322b37
mvandeberg added a commit that referenced this issue Oct 31, 2019
@mvandeberg
Fix active auth tests to use a testing authority #458
c9dadd2
@mvandeberg mvandeberg mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Active Testing Auth steemit/steem-js
1 participant
@mvandeberg