New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W29: Whitelabel AWS CDK generated block egress rule #590

Open

Poweranimal opened this issue Feb 9, 2022 · 0 comments

Poweranimal commented Feb 9, 2022

Hi,

The AWS CDK generates the following block all egress rule for SecurityGroups:

...
"SecurityGroupEgress": [
  {
    "CidrIp": "255.255.255.255/32",
    "Description": "Disallow all traffic",
    "FromPort": 252,
    "IpProtocol": "tcp",
    "ToPort": 86
  }
]
...

The rational for this rule can be found here:
https://github.com/aws/aws-cdk/blob/9975ec8ba98fcef7156148d9af79adfdb171514a/packages/%40aws-cdk/aws-ec2/lib/security-group.ts#L621

Though, the generated egress rule fails the W29 (= Security Groups found egress with port range instead of just a single port).

I would suggest to whitelabel this rule for W29.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment