New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min and max angularjs validators #4

Open

brevleq opened this issue Mar 10, 2015 · 0 comments

brevleq commented Mar 10, 2015

Hi, I believe that the override of min and max's validation could be a good improvement in your code:

ctrl.$validators.min = function (modelValue) {
      return angular.isDefined(attr.min) && attr.min!==null ? modelValue >= attr.min : true;
};

ctrl.$validators.max = function (modelValue) {
      return angular.isDefined(attr.max) && attr.max!==null ? modelValue <= attr.max : true;
};

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment