From 7c170dcc036bb4b2eaea55814905b07593c63a7c Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Wed, 10 Jul 2024 11:44:10 -0500 Subject: [PATCH] Raise minimum Go version to 1.21 There have apparently been some bug fixes related to generics in recent releases. This causes problems when using Gofish with older Go releases where it does not like the contraints defined on some of the recent updates using generics. This raises our minimum to 1.21 as this is a version known to work. While I would have liked to keep the minimum version older to give more flexibility to library consumers, there are multiple good reasons to update to the newer release. I do feel bad about the very short notice though. Signed-off-by: Sean McGinnis --- .github/workflows/check.yml | 4 ++-- go.mod | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c95f8b40..011f5db6 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -19,7 +19,7 @@ jobs: - name: Setup Go uses: actions/setup-go@v5 with: - go-version: '1.22.0' + go-version: '1.21' # Build the code - name: Run build @@ -39,7 +39,7 @@ jobs: - name: Setup Go uses: actions/setup-go@v5 with: - go-version: '1.22.0' + go-version: '1.21' - name: Run golangci-lint uses: golangci/golangci-lint-action@v6 diff --git a/go.mod b/go.mod index 18f07a4c..3f5d69cc 100644 --- a/go.mod +++ b/go.mod @@ -1,3 +1,3 @@ module github.com/stmcginnis/gofish -go 1.18 +go 1.21