Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding of UTF8 strings is fucked up #29

Open
capaj opened this issue Feb 1, 2017 · 1 comment
Open

encoding of UTF8 strings is fucked up #29

capaj opened this issue Feb 1, 2017 · 1 comment

Comments

@capaj
Copy link

capaj commented Feb 1, 2017

if you ever plan to put unicode characters into URL, don't use this library, because it's encoding to URI is totally broken for UTF8 strings.

For example a string:
špác is serialized like: %u0161p%E1c'

When in fact, it should be:

encodeURIComponent('špác')
"%C5%A1p%C3%A1c"
@capaj capaj changed the title encoding is fucked up encoding of UTF8 strings is fucked up Feb 1, 2017
@sjcalamia
Copy link

sjcalamia commented Feb 6, 2018

\u161 is the proper unicode character for š
http://www.amp-what.com/unicode/search/latin%20small%20letter%20s%20hacek
and
\uE1 is the proper unicode character for á
http://www.amp-what.com/unicode/search/latin%20small%20letter%20a%20acute

You seem to be hoping for double-byte unicode character support. I don't think the library is at fault here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants