Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add "Automatic-Module-Name" manifest entry #1220

Open
ao-apps opened this issue Jun 11, 2021 · 2 comments
Open

Please add "Automatic-Module-Name" manifest entry #1220

ao-apps opened this issue Jun 11, 2021 · 2 comments
Labels

Comments

@ao-apps
Copy link

ao-apps commented Jun 11, 2021

Please add "Automatic-Module-Name" manifest entry, defining a stable, future-proof module name. This will allow us on Java 9+ to use the API with confidence.

The module name will typically be the top-most package in the project, so I suggest "com.stripe".

Thank you,

  • Dan
@remi-stripe
Copy link
Contributor

@aoindustries Thanks for the report, we'll have a look internally to see how to address this

@ao-apps
Copy link
Author

ao-apps commented Jul 1, 2021

Or, better yet, provide a fully functional module-info.class.

Can place in root of JAR: https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html

Or, can use MRJAR and place in META-INF/versions/9: https://www.baeldung.com/maven-multi-release-jars

Please note, in our experience in Java 11, placing module-info.class in root of JAR allows for javadocs with Module sections. Placing in MRJAR generates javadocs that are not module-aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants