Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with deprecation alerts #199

Closed
LonsterMonster opened this issue Jul 22, 2023 · 2 comments · May be fixed by #203
Closed

Problem with deprecation alerts #199

LonsterMonster opened this issue Jul 22, 2023 · 2 comments · May be fixed by #203
Assignees
@JJJ
Labels
bug duplicate
Milestone
3.0.0

Comments

@LonsterMonster
Copy link

LonsterMonster commented Jul 22, 2023 •
edited
Loading

I enabled the log in the wp config as it helps me make sure everything is correct when installing stuff to my install of wp and installed the plugin to see how it was and got these deprecation errors

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php on line 245

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php on line 55

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php on line 57

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php on line 59

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php on line 61

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php on line 64

Deprecated: Constant FILTER_SANITIZE_STRING is deprecated in /home/u464391981/domains/contribucraft.com/public_html/wp-content/plugins/wp-multi-network/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php on line 437
@SteelWagstaff
Copy link
Contributor

FILTER_SANITIZE_STRING was deprecated as of PHP 8.1. The documentation recommends using htmlspecialchars() instead: https://www.php.net/manual/en/filter.filters.sanitize.php. See https://stackoverflow.com/a/69207369 for a discussion of other methods to achieve a similar outcome.

JJJ added a commit that referenced this issue Sep 19, 2024
@JJJ
General: remove FILTER_SANITIZE_STRING usages
6529de6 
See #199.
JJJ added a commit that referenced this issue Sep 19, 2024
@JJJ
General: remove trim() that is not needed
4456365 
See #199.
@JJJ JJJ mentioned this issue Sep 19, 2024
Draft
@JJJ JJJ mentioned this issue Jan 29, 2025
Closed
@JJJ
Copy link
Collaborator

JJJ commented Jan 29, 2025

Fixed via #210.

More filter_var() changes incoming via #203.

@JJJ JJJ closed this as completed Jan 29, 2025
@JJJ JJJ added this to the 3.0.0 milestone Jan 29, 2025
@JJJ JJJ self-assigned this Jan 29, 2025
JJJ added a commit that referenced this issue Jan 29, 2025
@JJJ
Merge branch 'master' of github.com:stuttter/wp-multi-network into is…
d82fa52 
…sue/199

Includes fixes/changes to form action creation & escaping.

See #199.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JJJ JJJ

Labels
bug duplicate
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Issue/199 - PHP8.1 compat stuttter/wp-multi-network
3 participants
@JJJ @LonsterMonster @SteelWagstaff