Secure headers, reduce static content size #302
Conversation
... Android Chrome Beta
change type of field couchpotato_password to password
| data=attr;} | ||
| object=getObject(data.indexOf("{")<0?"{"+data+"}":data);} | ||
| $.data(elem,settings.single,object);return object;}}});$.fn.metadata=function(opts){return $.metadata.get(this[0],opts);};})(jQuery) |
There was a problem hiding this comment.
Minimized JS should not be included, since it can't be modified.
Instead, a script should be given to minify (or compile) source at first launch.
There was a problem hiding this comment.
I cant see the problem, why would js librarys be modyfyed? It makes no sense.
There was a problem hiding this comment.
Just because of their license. GPL enforces the fact that you should be able to modify them.
Yes, it's the open-source thing. But usually, a simple Makefile with a call to a minifier should do the trick
|
Seems like nonsense, it's still possible to modify a file even if it's minified. If that's a problem I can replace the files I have minified with the authors own minified file.. |
|
OK, I understand this is a hard debate that triggered a lot of flame wars. But no, a minified file is not a source file. It is like a compiled binary. I can modify a binary using an hex editor, however, providing a compiled binary is not releasing a software as open-sourced. I'm sorry to be so much a pain, but minified script are complicated to handle: it's difficult to compare them with their original source to know if they were not altered for example. |
|
Feel free to send a pr regarding the makefile, I cba. @styxit feel free to close this. |
|
This is a good idea! I took the liberty of grabbing your minified versions. I've been in the foss game for well over 15 years: http://www.who.is/whois/openscripts.com and this is the stupidest thing I've ever heard, and believe me, I've heard plenty of stupid shit said! |
|
@madclicker great, I was gonna push this to pytunes aswell |
|
https://lists.debian.org/debian-devel/2014/03/msg00190.html |
|
I know nothing about about licenses. I can google tho https://www.gnu.org/licenses/javascript-labels.html. I just don't care. The file you dropped the note about was dual licensed with mit so I hope I can just add license info at the top. |
|
FOSS is not about formatting. Hellowlol only reformatted the originals. The original formatted source is still available. @Hellowlol What did you use to minify the js? Does it work for css? I think after the project reaches stability this would be good for all js and css TEXT files. |
|
I just grabbed the optimized version that pagespeed linked to and manually pasted that into the file. (To keep version info etc). I have no idea, we should use some other tool where this can be automated on run time. |
|
Very often my requests take a long time, so gaining some performance is something i would like to achieve and think this is a good start. About the licences for JS libraries; Maybe we should include the original source and a minified version, and only use the minified version? |
|
Can do :) |
|
@styxit No problem. After all, I've just checked your license, and you're on MIT. Since jQuery is also on MIT (and on GPL, but you can chose the one you prefer), I think it should be OK to have both side by side (jquery.js.dist for example). Sorry for the noise. I just wanted to avoid a future trouble, but I am clearly not on duty to hunt this issues 😉 HTPC-manager is a great software, and I'm still using it anyway! |
Closes #272
This is just to clean up some of the issues that should be closed:
Closes #279
Closes #284
Closes #236
Closes #235
Closes #171
Closes #166
Closes #162
Closes #144 i cant find any ref to the missing image in the code now
Closes #126 Works fine now
Closes #122