chore(example): fix example #265
Conversation
Pull Request Test Coverage Report for Build 12947462764Details
💛 - Coveralls |
| headers = {"Prefer": "return=representation"} | ||
|
|
||
| # does not match filter and will therefore only be received by the * listen, but not the INSERT listen | ||
| requests.post( |
There was a problem hiding this comment.
Am I correct in thinking the requests library is used here purely for testing purpose? if yes then I don't think this should be in the example as users will blindly copy this without understanding what is going on. Rather instructions should be left in a README on how to run the example and call the endpoints from a HTTP GUI client or CURL.
There was a problem hiding this comment.
Yes, @silentworks, the example is only for testing purposes. It is there to have a quick app to run and test the real-time implementation, actually. But thinking more about that, maybe it is better to remove this example and use an integration test instead.
What do you think?
There was a problem hiding this comment.
Yeah if its for testing purpose only then it should be in the tests directory as an integration test instead. This is how we've structured the postgrest-py repo, it has normal unit tests and integration tests inside of the tests directory.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.