Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development condition is flaky #17

Open
benmccann opened this issue Oct 29, 2024 · 1 comment
Open

development condition is flaky #17

benmccann opened this issue Oct 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@benmccann
Copy link
Collaborator

Describe the bug

sveltejs/svelte#14022

Reproduction URL

?

Reproduction

the linked issue uses esm-env. would need to somehow change it to use node-conditions. maybe rename node-conditions to esm-env locally and then use it via overrides

Logs

No response

System Info

node 20.17.0

Severity

blocking all usage of node-conditions

@benmccann benmccann added the bug Something isn't working label Oct 29, 2024
@dominikg
Copy link
Contributor

so this is a doozy. the bug only seems to appear if you use a dependency that also depends on esm-env.

pnpx sv create, dev works fine
pnpm i -D bits-ui and adding a component of them, dev works fine
pnpm i -D bits-ui@^1.0.0-next.0 and dev breaks

my current working theory is that it is connected with the optimizer and the extra indirection of the subpath "reexport".

the tests in this repo using node -C development show it works fine though, really strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants