Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaAcknowledgedMessage lacks headers #144

Open
blindspotbounty opened this issue Nov 13, 2023 · 1 comment
Open

KafkaAcknowledgedMessage lacks headers #144

blindspotbounty opened this issue Nov 13, 2023 · 1 comment
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.

Comments

@blindspotbounty
Copy link
Collaborator

We use kafka headers to store technical information about message.
However, it was surprising that there are no headers in KafkaAcknowledgedMessage.

Could you advise whether there are plans to add it at some point, please?

@FranzBusch
Copy link
Contributor

I think we can easily add this. We just need to parse the headers out of the underlying rd message pointer. Feel free to open a PR.

@FranzBusch FranzBusch added the good first issue Good for newcomers label Nov 17, 2023
@FranzBusch FranzBusch added the kind/enhancement Improvements to existing feature. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement Improvements to existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants