-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use custom ChallengeGenerator #72
Comments
@dscreve what are you looking to do with a custom challenge generator? It's an internal implementation detail at the moment |
I’m running a stateless environment : I cannot store challenge in session but I need to check if challenge is trusted and can be used in current context. So I need to put custom info in it (even if it contains random data).David ScrèveLe 12 juil. 2024 à 19:19, Tim Condon ***@***.***> a écrit :
@dscreve what are you looking to do with a custom challenge generator? It's an internal implementation detail at the moment
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Nothing is preventing you from repackaging ie. Just make your own codable type with similar fields. The JS side can also transform this in any way you need, the browser isn't requesting this directly. |
Actually, implicit init function is internal, making creation of PublicKeyCredentialCreationOptions impossible.David ScrèveLe 12 juil. 2024 à 21:35, Dimitri Bouniol ***@***.***> a écrit :
Nothing is preventing you from repackaging PublicKeyCredentialCreationOptions with your own challenge, though the challenge must be independently verifiable, otherwise you open yourself up to replay attacks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ChallengeGenerator::generate is internal...Then creation of custom ChallengeGenerator is not permitted...and WebAuthnManager::challengeGenerator is private.
The text was updated successfully, but these errors were encountered: