Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a filter for publish workflow on queries #177

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

a filter for publish workflow on queries #177

wants to merge 2 commits into from

Conversation

dbu
Copy link
Member

@dbu dbu commented Aug 25, 2015

fix #126

you have to call the filter manually as there is no event or filter system like with the ORM.

for now it only works with the ODM query builder. not with phpcr query builder or sql2. we don't have a DQL, right?

something is wrong with the publishStartDate query but i did not find out what. i reduced it to this but still did not work:

SELECT * 
FROM [nt:unstructured] AS a 
WHERE (
    a.publishStartDate <= CAST('2015-08-25T20:23:44.000+02:00' AS DATE) 
   AND (a.[phpcr:class] = 'Symfony\Cmf\Bundle\CoreBundle\Tests\Resources\Document\Publishable' 
         OR a.[phpcr:classparents] = 'Symfony\Cmf\Bundle\CoreBundle\Tests\Resources\Document\Publishable'
    )
)

i checked the sqlite database and for the /published document, the property is

<sv:property sv:name="publishStartDate" sv:type="Date" sv:multi-valued="0">
    <sv:value length="29">2015-08-23T22:00:00.000+00:00</sv:value>
</sv:property>

@dbu
Copy link
Member Author

dbu commented Aug 25, 2015

@dantleech any idea about the date query?

@lsmith77 lsmith77 added review and removed wip/poc labels Aug 26, 2015
@dbu
Copy link
Member Author

dbu commented Sep 20, 2015

ping @dantleech do you have an idea about the date query issue i am seeing?

@dbu
Copy link
Member Author

dbu commented Jan 9, 2016

ping @dantleech

@dantleech
Copy link
Member

oops, sorry. That query is generated by jackalope right?

Running a similar query I get an exception when I use the <= operator on both Jackalope and Jackrabbit.

@dbu
Copy link
Member Author

dbu commented Jan 11, 2016

okay, found it again: jackalope/jackalope-doctrine-dbal#267 says this is not supported with doctrine dbal. we only test this bundle with dbal, so we can't functionally test the feature.

not sure how hard fixing the CAST part of jackalope/jackalope-doctrine-dbal#267 would be, but this is blocked by that.

@ElectricMaxxx
Copy link
Member

Any chances to get this one closed?

@dbu
Copy link
Member Author

dbu commented Feb 17, 2016

@ElectricMaxxx if somebody can either find a query that works or implement the missing bits in jackalope to make this query work. i don't have time to work on this at the moment...

@ElectricMaxxx
Copy link
Member

I don't that this is a blocker for the release, right?

So we can skip that - i think.

Am 17.02.2016 um 09:20 schrieb David Buchmann:

@ElectricMaxxx https://github.com/ElectricMaxxx if somebody can
either find a query that works or implement the missing bits in
jackalope to make this query work. i don't have time to work on this
at the moment...

—
Reply to this email directly or view it on GitHub
#177 (comment).

@dbu
Copy link
Member Author

dbu commented Feb 17, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish workflow, querying published content only
4 participants
@dbu @dantleech @ElectricMaxxx @lsmith77