Skip to content

Commit 2ded754

Browse files
committed
minor #2069 [ux.symfony.com] Fix rendering/color issues on Map page (Kocal)
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [ux.symfony.com] Fix rendering/color issues on Map page | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> It looks like we have some visual issues in light mode on the Map page, we can't see the menu: <img width="1501" alt="Capture d’écran 2024-08-15 à 07 42 21" src="https://github.com/user-attachments/assets/6a39c912-3cc3-4b73-82a5-16a5aa751d1e"> And we miss the `composer require ...` thing. I've Replaced the usage of the new component `Hero` (introduced in #2053) by the good old `PackageHeader` component. This is the quickest solution right now to correctly render UX Map page, and it gives us some times to improve this `Hero` component and re-use it in all UX package pages. **EDIT:** I've seen with `@smnandre` for some minor adjustements: <img width="1512" alt="image" src="https://github.com/user-attachments/assets/8544f46a-37aa-4b1e-964e-380174a2d0c5"> <img width="1510" alt="image" src="https://github.com/user-attachments/assets/b7617ebe-f014-4e50-a3b3-c78f5045b552"> Commits ------- c3a8806 [ux.symfony.com] Fix rendering/color issues on Map page
2 parents 4f1862e + c3a8806 commit 2ded754

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

ux.symfony.com/assets/styles/components/_PackageHeader.scss

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.PackageHeader {
22
h1 {
33
text-shadow: 0 .25rem .25rem rgba(0, 0, 0, .05);
4+
text-wrap: balance;
45

56
em {
67
display: inline-flex;

ux.symfony.com/src/Service/UxPackageRepository.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ public function findAll(?string $query = null): array
3737
'map',
3838
'UX Map',
3939
'app_map',
40-
'#fff',
41-
// 'linear-gradient(to bottom right, #58D984EB, #0083A2D1), #3386dfd4',
40+
'#1BA980',
4241
'linear-gradient(to bottom right, #1BA980, #209127 75%, #C0CB2A)',
4342
'Interactive Maps',
4443
'Render interactive Maps in PHP with Leaflet or Google Maps.',

ux.symfony.com/templates/ux_packages/map.html.twig

+12-9
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,18 @@
33
{% set package = 'map'|ux_package %}
44

55
{% block package_header %}
6-
<twig:Hero
7-
eyebrows="Assert('Mapper')"
8-
title="UX Map"
9-
url="{{ url('app_map') }}"
10-
>
11-
Embed <code>interactive maps</code> in your Symfony application in a breeze!
12-
<br />
13-
Decouple your code from your map provider: <code>Google Maps</code>, <code>LeaftLet</code>.
14-
</twig:Hero>
6+
{% component PackageHeader with {
7+
package: 'map',
8+
eyebrowText: 'Seamless Maps Integration',
9+
} %}
10+
{% block title_header %}
11+
Embed <em>interactive maps</em> in a breeze!
12+
{% endblock %}
13+
14+
{% block sub_content %}
15+
Decouple your code from your map provider: <em>Google Maps</em>, <em>LeaftLet</em>.
16+
{% endblock %}
17+
{% endcomponent %}
1518
{% endblock %}
1619

1720
{% block code_block_left %}

0 commit comments

Comments
 (0)