Skip to content

Commit

Permalink
Added settings redirect for cloud.
Browse files Browse the repository at this point in the history
  • Loading branch information
mikecao committed Aug 27, 2023
1 parent f2f5517 commit cc574e6
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 17 deletions.
4 changes: 3 additions & 1 deletion next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ if (process.env.TRACKER_SCRIPT_NAME) {
const redirects = [
{
source: '/settings',
destination: process.env.CLOUD_MODE ? '/settings/profile' : '/settings/websites',
destination: process.env.CLOUD_MODE
? `${process.env.CLOUD_URL}/settings/websites`
: '/settings/websites',
permanent: true,
},
];
Expand Down
10 changes: 4 additions & 6 deletions src/components/layout/NavBar.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,24 @@
import { Icon, Text, Row, Column } from 'react-basics';
import Link from 'next/link';
import { useRouter } from 'next/router';
import classNames from 'classnames';
import Icons from 'components/icons';
import ThemeButton from 'components/input/ThemeButton';
import LanguageButton from 'components/input/LanguageButton';
import ProfileButton from 'components/input/ProfileButton';
import styles from './NavBar.module.css';
import useConfig from 'components/hooks/useConfig';
import useMessages from 'components/hooks/useMessages';
import { useRouter } from 'next/router';
import HamburgerButton from '../common/HamburgerButton';
import HamburgerButton from 'components/common/HamburgerButton';
import styles from './NavBar.module.css';

export function NavBar() {
const { pathname } = useRouter();
const { cloudMode } = useConfig();
const { formatMessage, labels } = useMessages();

const links = [
{ label: formatMessage(labels.dashboard), url: '/dashboard' },
{ label: formatMessage(labels.websites), url: '/websites' },
{ label: formatMessage(labels.reports), url: '/reports' },
!cloudMode && { label: formatMessage(labels.settings), url: '/settings' },
{ label: formatMessage(labels.settings), url: '/settings' },
].filter(n => n);

return (
Expand Down
4 changes: 2 additions & 2 deletions src/components/pages/reports/FieldFilterForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function FieldFilterForm({
type,
values,
onSelect,
includeOnlyEquals,
allowFilterSelect = true,
}) {
const { formatMessage, labels } = useMessages();
const [filter, setFilter] = useState('eq');
Expand All @@ -34,7 +34,7 @@ export default function FieldFilterForm({
<Form>
<FormRow label={label} className={styles.filter}>
<Flexbox gap={10}>
{!includeOnlyEquals && (
{allowFilterSelect && (
<Dropdown
className={styles.dropdown}
items={filters}
Expand Down
4 changes: 2 additions & 2 deletions src/components/pages/reports/FilterSelectForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function useValues(websiteId, type) {
return { data, error, isLoading };
}

export default function FilterSelectForm({ websiteId, items, onSelect, includeOnlyEquals }) {
export default function FilterSelectForm({ websiteId, items, onSelect, allowFilterSelect }) {
const [field, setField] = useState();
const { data, isLoading } = useValues(websiteId, field?.name);

Expand All @@ -37,7 +37,7 @@ export default function FilterSelectForm({ websiteId, items, onSelect, includeOn
type={field?.type}
values={data}
onSelect={onSelect}
includeOnlyEquals={includeOnlyEquals}
allowFilterSelect={allowFilterSelect}
/>
);
}
4 changes: 2 additions & 2 deletions src/components/pages/settings/websites/TrackingCode.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import useConfig from 'components/hooks/useConfig';

export function TrackingCode({ websiteId }) {
const { formatMessage, messages } = useMessages();
const { basePath, trackerScriptName } = useConfig();
const { basePath, trackerScriptName, trackerScriptOrigin } = useConfig();
const url = trackerScriptName?.startsWith('http')
? trackerScriptName
: `${location.origin}${basePath}/${
: `${trackerScriptOrigin || location.origin}${basePath}/${
trackerScriptName?.split(',')?.map(n => n.trim())?.[0] || 'script.js'
}`;

Expand Down
6 changes: 2 additions & 4 deletions src/components/pages/websites/WebsiteMetricsBar.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import classNames from 'classnames';
import { useApi, useDateRange, useMessages, usePageQuery, useSticky } from 'components/hooks';
import RefreshButton from 'components/input/RefreshButton';
import WebsiteDateFilter from 'components/input/WebsiteDateFilter';
import MetricCard from 'components/metrics/MetricCard';
import MetricsBar from 'components/metrics/MetricsBar';
Expand All @@ -10,7 +9,7 @@ import { formatShortTime } from 'lib/format';
import { Button, Column, Icon, Icons, Popup, PopupTrigger, Row } from 'react-basics';
import styles from './WebsiteMetricsBar.module.css';

export function WebsiteMetricsBar({ websiteId, showFilter = true, showRefresh = true, sticky }) {
export function WebsiteMetricsBar({ websiteId, showFilter = true, sticky }) {
const { formatMessage, labels } = useMessages();

const { get, useQuery } = useApi();
Expand Down Expand Up @@ -88,7 +87,7 @@ export function WebsiteMetricsBar({ websiteId, showFilter = true, showRefresh =
handleAddFilter(value);
close();
}}
includeOnlyEquals={true}
allowFilterSelect={false}
/>
</PopupForm>
);
Expand Down Expand Up @@ -161,7 +160,6 @@ export function WebsiteMetricsBar({ websiteId, showFilter = true, showRefresh =
<Column defaultSize={12} xl={4}>
<div className={styles.actions}>
{showFilter && <WebsiteFilterButton />}
{showRefresh && <RefreshButton websiteId={websiteId} />}
<WebsiteDateFilter websiteId={websiteId} />
</div>
</Column>
Expand Down

0 comments on commit cc574e6

Please sign in to comment.