Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Important alert unreadable #2194

Open
kevinpapst opened this issue Mar 3, 2025 · 0 comments
Open

[BUG] Important alert unreadable #2194

kevinpapst opened this issue Mar 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@kevinpapst
Copy link
Collaborator

kevinpapst commented Mar 3, 2025

Describe the bug

This is a follow-up of #2141 - I create this bug post, as I guess my comment goes unnoticed otherwise.

The alters were recently refactored and some parts are worse now:

  • The "important" version is not popping out any more, I use them for toast messages and they will not work like that.
    -Even more important: they are hard to read now. Regular mode is already hard to read, but dark mode is literally impossible: I cannot read the new danger+warning at all. And I am only wearing "normal" glasses (like every IT person who looked at screens for 30+ years). The red and orange font is so blurry, that it is impossible to identify the text.

I would vote to revert the changes for the important alerts completely, they were perfect before (for my use-cases):

  • If you prefer the new version, can we please get the old ones back as additional classes?
  • Such brutal changes are BC breaks in my opinion and should be avoided

How to reproduce

Refactored in #2141

Preview see https://preview.tabler.io/alerts.html?theme=dark

Screenshots

I am using this "Accessibility insights for Web" plugin and it also reports contrast issues on these elements (the grey text and the red text especially):
Bildschirmfoto 2025-02-28 um 09 23 55
Bildschirmfoto 2025-02-28 um 09 24 24

Before
Bildschirmfoto 2025-02-28 um 00 36 59

Bildschirmfoto 2025-02-28 um 00 39 27

After
Bildschirmfoto 2025-02-28 um 00 37 11

Bildschirmfoto 2025-02-28 um 00 39 16

JSFiddle

No response

@kevinpapst kevinpapst added the bug Something isn't working label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant