refactor(ast): convert union types to const arrays (#1733)

Author: i582

knip.json

@@ -4,6 +4,7 @@
   "project": ["src/**/*.ts"],
   "ignore": [
     "src/ast/ast.ts",
+    "src/ast/ast-constants.ts",
     "src/config/parseConfig.ts",
     "src/ast/ast-printer.ts",
     "src/error/display-to-json.ts",

src/ast/ast-constants.ts

@@ -0,0 +1,107 @@
+import { keys } from "../utils/tricks";
+import {
+    AstAugmentedAssignOperation,
+    AstBinaryOperation,
+    AstFunctionAttributeName,
+    AstNumberBase,
+    AstUnaryOperation,
+    ImportType,
+} from "./ast";
+
+const augmentedAssignOperationsRecord: Record<
+    AstAugmentedAssignOperation,
+    true
+> = {
+    "+": true,
+    "-": true,
+    "*": true,
+    "/": true,
+    "&&": true,
+    "||": true,
+    "%": true,
+    "|": true,
+    "<<": true,
+    ">>": true,
+    "&": true,
+    "^": true,
+};
+
+export const astAugmentedAssignOperations = Object.freeze(
+    keys(augmentedAssignOperationsRecord),
+);
+
+const binaryOperationsRecord: Record<AstBinaryOperation, true> = {
+    "+": true,
+    "-": true,
+    "*": true,
+    "/": true,
+    "!=": true,
+    ">": true,
+    "<": true,
+    ">=": true,
+    "<=": true,
+    "==": true,
+    "&&": true,
+    "||": true,
+    "%": true,
+    "<<": true,
+    ">>": true,
+    "&": true,
+    "|": true,
+    "^": true,
+};
+
+export const astBinaryOperations = Object.freeze(keys(binaryOperationsRecord));
+
+const unaryOperationsRecord: Record<AstUnaryOperation, true> = {
+    "+": true,
+    "-": true,
+    "!": true,
+    "!!": true,
+    "~": true,
+};
+
+export const astUnaryOperations = Object.freeze(keys(unaryOperationsRecord));
+
+const numberBasesRecord: Record<AstNumberBase, true> = {
+    2: true,
+    8: true,
+    10: true,
+    16: true,
+};
+
+export const astNumberBases = Object.freeze(
+    keys(numberBasesRecord).map(Number),
+);
+
+const importTypesRecord: Record<ImportType, true> = {
+    stdlib: true,
+    relative: true,
+};
+
+export const importTypes = Object.freeze(keys(importTypesRecord));
+
+type ConstantAttributeName = "virtual" | "override" | "abstract";
+
+const constantAttributeNamesRecord: Record<ConstantAttributeName, true> = {
+    virtual: true,
+    override: true,
+    abstract: true,
+};
+
+export const astConstantAttributeNames = Object.freeze(
+    keys(constantAttributeNamesRecord),
+);
+
+const functionAttributeNamesRecord: Record<AstFunctionAttributeName, true> = {
+    mutates: true,
+    extends: true,
+    virtual: true,
+    abstract: true,
+    override: true,
+    inline: true,
+};
+
+export const astFunctionAttributeNames = Object.freeze(
+    keys(functionAttributeNamesRecord),
+);

src/ast/random.infra.ts

@@ -2,6 +2,7 @@ import fc from "fast-check";
 import * as A from "./ast";
 import { dummySrcInfo } from "../grammar/src-info";
 import { diffJson } from "diff";
+import { astBinaryOperations, astUnaryOperations } from "./ast-constants";
 
 /**
  * An array of reserved words that cannot be used as contract or variable names in tests.
@@ -100,7 +101,7 @@ function randomAstOpUnary(
     return dummyAstNode(
         fc.record({
             kind: fc.constant("op_unary"),
-            op: fc.constantFrom("+", "-", "!", "!!", "~"),
+            op: fc.constantFrom(...astUnaryOperations),
             operand: operand,
         }),
     );
@@ -112,26 +113,7 @@ function randomAstOpBinary(
     return dummyAstNode(
         fc.record({
             kind: fc.constant("op_binary"),
-            op: fc.constantFrom(
-                "+",
-                "-",
-                "*",
-                "/",
-                "!=",
-                ">",
-                "<",
-                ">=",
-                "<=",
-                "==",
-                "&&",
-                "||",
-                "%",
-                "<<",
-                ">>",
-                "&",
-                "|",
-                "^",
-            ),
+            op: fc.constantFrom(...astBinaryOperations),
             left: leftExpression,
             right: rightExpression,
         }),

src/utils/tricks.ts

@@ -146,3 +146,5 @@ export const singleton = <K extends string | symbol, V>(key: K, value: V) => {
 export const entries = Object.entries as <O>(
     o: O,
 ) => { [K in keyof O]: [K, O[K]] }[keyof O][];
+
+export const keys = Object.keys as <O>(o: O) => (keyof O)[];