Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use single port #56

Open
wass3r opened this issue Sep 13, 2018 · 3 comments
Open

Refactor to use single port #56

wass3r opened this issue Sep 13, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request to do
Milestone

Comments

@wass3r
Copy link
Collaborator

wass3r commented Sep 13, 2018

Currently we expose three ports, for:

  1. Prometheus (8080)
  2. Slack Events API Receiver (3000)
  3. Slack Interactions API Receiver (4000)

Consider refactoring to use a single port. Provide an ability to register a handler for any path and by default register handlers for the above, if applicable.

Also, add a configuration option to set the port the user wants to use.

This will reduce number of ports to expose/manage and allow easier deployments in some cases.

@wass3r wass3r added the enhancement New feature or request label Sep 13, 2018
@wass3r wass3r added this to the Refactor milestone Oct 8, 2018
@wass3r wass3r added the to do label Oct 8, 2018
@wass3r wass3r moved this to To do in flottbot Sep 10, 2022
@wass3r wass3r added this to flottbot Sep 10, 2022
@wass3r wass3r moved this from To do to In progress in flottbot Sep 12, 2022
@wass3r wass3r self-assigned this Sep 12, 2022
@wass3r
Copy link
Collaborator Author

wass3r commented Jan 6, 2023

will take the opportunity to also move from gorilla/mux to something else since that is now archived. currently, thinking of go-chi/chi since it's close and offers some other niceties such as no dependencies, etc. however, maybe just sticking to standard library is sufficient.

@Nepo26
Copy link

Nepo26 commented Oct 8, 2024

Hey @wass3r, how is the development? Any timeline on this? Need help with anything?

@wass3rw3rk
Copy link
Member

@Nepo26 thanks for the interest. not as fast as i hoped :) i had a refactor started that would allow each remote to register endpoints if needed and also set up common ones for metrics/health and then start (one) server with any configured endpoints; i can't commit to a deadline, but i will try to revive that here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to do
Projects
Status: In progress
Development

No branches or pull requests

3 participants