Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angularjs Node Leaks #1335

Closed
samccone opened this issue Jun 7, 2015 · 6 comments
Closed

Angularjs Node Leaks #1335

samccone opened this issue Jun 7, 2015 · 6 comments

Comments

@samccone
Copy link
Member

samccone commented Jun 7, 2015

Steps to reproduce
  • start timeline profiler
    • add three todos
    • delete three todos
    • (repeat above 2 more times)
  • force GC
  • stop timeline profiler

screen shot 2015-06-06 at 8 57 17 pm
screen shot 2015-06-06 at 8 57 12 pm


Looks like we are leaking DOM nodes ⛲

@samccone
Copy link
Member Author

samccone commented Jun 7, 2015

ping @IgorMinar

@sindresorhus
Copy link
Member

@btford Do you know anyone on the Angular team able to look at this?

@btford
Copy link

btford commented Aug 21, 2015

Idk if this definitively proves a memory leak. @samccone – if you repeat these steps, does memory continue (unbounded) to grow?

What version of Angular do you see this? And do you see this behavior in browsers besides Chrome?

It's probably good to cross-file this on angular/angular.js, but I'll ping the team and see if anyone can take a look.

Thanks!

@samccone
Copy link
Member Author

Hey @btford Let me update these numbers with the most recent results 👍

@arthurvr
Copy link
Member

arthurvr commented Oct 1, 2015

It's probably good to cross-file this on angular/angular.js, but I'll ping the team and see if anyone can take a look.

Thanks. Has someone been able to look into this yet? :)

@flashdesignory
Copy link
Collaborator

Closing, since the Angular example was updated #2212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants