Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEDO breaking change vedo.Picture to vedo.Image #224

Open
clemens-fricke opened this issue Jan 28, 2025 · 2 comments
Open

VEDO breaking change vedo.Picture to vedo.Image #224

clemens-fricke opened this issue Jan 28, 2025 · 2 comments

Comments

@clemens-fricke
Copy link
Collaborator

Vedo made a breaking change in the newest release 2024.5.3 on 27.01.2025. According to the Changelog there are the following soft-breaking Changes:

Soft-breaking Changes

Changes that may break existing code whose fixing is trivial:

    change object.points() to object.points everywhere.
    change object.cell_centers to object.cell_centers().points everywhere.
    change Picture() to Image() everywhere.

We are using vedo.Picture and have to rename all occurrences. That would mean that we have to make the minimum vedo release to 2024.5.3. They have not minted the release yet though the repository has the main branch already on the breaking version. I would at least wait until they mint the release to do this.

Alternatively, we could say that the version should be lower than the now coming release. I would advise against it since, that way, we hinder future development and possible fixes.

@j042
Copy link
Member

j042 commented Jan 30, 2025

I agree, no reason to fix a version for that. Don't we just use it as an allowed type for a show_option? What about an if block or try-except block during import to load a suitable type?

@j042
Copy link
Member

j042 commented Jan 30, 2025

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants