Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] General task failure not reporting as LANG_FAIL in replayer #865

Open
cretz opened this issue Jan 23, 2025 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 23, 2025

Describe the solution you'd like

When a workflow is run that throws to cause a task failure (not a non-deterministic one though), when that history is run under replayer, the cache remove job has reason LANG_REQUESTED with "Always evict workflows after replay" as if it succeeded. The cache remove job reason is used to determine replay failure or not. Should probably be LANG_FAIL. Should also consider providing the activation failure on the remove job to help lang out.

Note, this is technically a backwards-incompatible behavior change because workflow histories with task failures will start failing in Core-based SDKs. Lang should have release notes saying as much.

@cretz cretz added the enhancement New feature or request label Jan 23, 2025
@cretz cretz changed the title [Feature Request] General task failure not reporting as LANG_FAIL [Feature Request] General task failure not reporting as LANG_FAIL in replayer Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant