Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown formatting for review content #375

Open
terror opened this issue Aug 24, 2023 · 8 comments
Open

Support markdown formatting for review content #375

terror opened this issue Aug 24, 2023 · 8 comments
Labels
good first issue Good for newcomers

Comments

@terror
Copy link
Owner

terror commented Aug 24, 2023

No description provided.

@terror terror added the good first issue Good for newcomers label Aug 24, 2023
@ronyboi
Copy link

ronyboi commented Apr 19, 2024

hey @terror and team,

I was pretty impressed by your work. I was wondering if you guys are open to other contributors? I am a McGill CS alum and am interested in picking up this ticket. Let me know what you guys think. Thanks!

@ronyboi
Copy link

ronyboi commented Apr 19, 2024

@terror
Copy link
Owner Author

terror commented Apr 19, 2024

hey @terror and team,

I was pretty impressed by your work. I was wondering if you guys are open to other contributors? I am a McGill CS alum and am interested in picking up this ticket. Let me know what you guys think. Thanks!

Hey Rohan! We're definitely open to contributors and would be happy if we got someone on this one. There is a minor thing we have to do to make it easier to contribute to with regard to dev environment variable exposure, once thats done we'll update the readme and it should be easy to get started.

@ronyboi
Copy link

ronyboi commented Apr 19, 2024

Sure. Let me know once that's done! Happy to contribute :)

@terror
Copy link
Owner Author

terror commented Apr 19, 2024

Sure. Let me know once that's done! Happy to contribute :)

We updated the readme, for now we're gonna require contributors to join the discord server to get the credentials needed to work on the project!

https://discord.gg/Eh6eZ27C

@ronyboi
Copy link

ronyboi commented Apr 20, 2024

Hi,

Do we want to support a markdown editor? We could consider adding https://uiwjs.github.io/react-md-editor/. That would be a bigger task.

@39bytes
Copy link
Collaborator

39bytes commented Apr 21, 2024

Do we even actually want this feature? I think this is a bad idea if unrestricted because things like markdown headers will kind of disrupt the page flow and be clunky.
Maybe only supporting a subset of markdown (bold/italic, etc) would be better.

@terror
Copy link
Owner Author

terror commented Apr 22, 2024

Do we even actually want this feature? I think this is a bad idea if unrestricted because things like markdown headers will kind of disrupt the page flow and be clunky. Maybe only supporting a subset of markdown (bold/italic, etc) would be better.

+1 for the subset, didn't think how headers would interrupt the flow of the page

We could potentially look into something like quill (https://github.com/zenoamaro/react-quill) for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants