Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of professors not offering the course appearing as teaching it #630

Open
Rico-CHEH opened this issue Jan 23, 2025 · 4 comments
Open

Comments

@Rico-CHEH
Copy link

Problem Description

For some courses such as comp 330 or math 547, the professors appearing as currently teaching does not coincide with the actual information on the website. Example below:

This shows that both Matthieu and Claude are supposed to teach the course for this winter semester, because originally Claude was supposed to teach it but it was changed in the middle of fall semester to Matthieu, since Claude left McGill. (Similar situation for math 547, because Linan Chen was supposed to teach it, but it got changed in the middle of last semester).
Image

Image

Idea

I didn't look too much at the code to try and find what caused it, but my guess is that whenever it detects a change in the page, it updates the database with the new prof, however it never checks whether the previous one remains.

Hope this helps

@terror
Copy link
Owner

terror commented Jan 27, 2025

Fixed in #631. Thanks for reporting! We're working on automating this type of manual data retrieval so stuff like this happens less often.

@terror terror closed this as completed Jan 27, 2025
@SamZhang02
Copy link
Collaborator

Reopening because the issue is still up on prod (? confusing

@atlasgong
Copy link
Contributor

atlasgong commented Feb 26, 2025

Not sure if it's a related issue but MATH 141's S2024 says the course was taught by Hovsep Mazakian but it was in fact taught by Elio Abi Younes. McGill's own website reflects this inaccurately, showing that both lecturers taught during S2024, but then why doesn't it show both names? Edit: see comment below

Image Image

https://www.mcgill.ca/study/2023-2024/courses/math-141

@atlasgong
Copy link
Contributor

Sorry I just realized there were two separate sessions for this course over the summer (potential root cause?), so the data from McGill's site is correct. But anyhow both lecturer names should be displayed

@terror terror moved this to Todo in mcgill.courses Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

4 participants