Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream source request configuration #205

Open
dotansimha opened this issue Dec 18, 2023 · 4 comments
Open

Upstream source request configuration #205

dotansimha opened this issue Dec 18, 2023 · 4 comments

Comments

@dotansimha
Copy link
Member

We can add configuration for the source level, not just endpoint.

Some ideas:

  • Method (POST/GET/something else)
  • Headers (static)

And in the future:

  • Subscription protocol (SSE/WS/polling)
@theguild-bot theguild-bot mentioned this issue Dec 18, 2023
63 tasks
@trkohler
Copy link
Contributor

trkohler commented Feb 4, 2024

hello, may I take this one? Seems like a relatively easy issue for onboarding to a project.

@dotansimha
Copy link
Member Author

dotansimha commented Feb 6, 2024

hello, may I take this one? Seems like a relatively easy issue for onboarding to a project.

Sure! Thank you! :) please let me know if we can help!

@trkohler
Copy link
Contributor

@dotansimha like that?

  "sources": [
    {
      "type": "graphql",
      "id": "my-source",
      "method": "POST",
      "headers": [
        { "Authorization": "string" },
        { "Content-Type": "string" },
        { "X-Custom-Header": "string" }
      ],
      "config": {
        "endpoint": "https://my-source.com/graphql"
      }
    }
  ],

@YassinEldeeb
Copy link
Member

Yes, exactly as you have described!
This would require extending the config to accept those new fields, and updating the engine executors to use the headers or method if supplied.

This was referenced May 7, 2024
@theguild-bot theguild-bot mentioned this issue May 23, 2024
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants