Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a metric exposing number of packages that were requested by a user but were not found as solved #724

Closed
fridex opened this issue Jun 24, 2021 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Contributor

fridex commented Jun 24, 2021

Is your feature request related to a problem? Please describe.

As a Thoth operator, I would like to know how many requests made to the system failed on an unsolved package. For this, I would like to observe a metric - the number of advisers that failed due to an unsolved package and correlate it to number of total adviser runs.

Can read as:

X% of advisers failed on unsolved package

This will expose how the data stored in the system are supporting Thoth user needs.

@fridex fridex added kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels Jun 24, 2021
@pacospace
Copy link
Contributor

pacospace commented Jun 28, 2021

Is your feature request related to a problem? Please describe.

As a Thoth operator, I would like to know how many requests made to the system failed on an unsolved package. For this, I would like to observe a metric - the number of advisers that failed due to an unsolved package and correlate it to number of total adviser runs.

Can read as:

X% of advisers failed on unsolved package

This will expose how the data stored in the system are supporting Thoth user needs.

We already collect every day this metric in adviser-reporter and store in on Ceph. We could send these metrics to pushgateway to have them in Grafana since there is no ETA on Superset. wdyt?

On Grafana currently we can see the number of unresolved messages sent by adviser workflow and exposed by investigator. This is shown in in the dashboards already: https://grafana-route-opf-monitoring.apps.zero.massopen.cloud/d/6576535a8b26fd1a0e5328f4413dfd8bc989f54f/thoth-kafka-consumers-and-argo-workflows?orgId=1&refresh=30s. This cannot be used for the metric requested in the issue though as adviser workflows are async.

@pacospace pacospace self-assigned this Jun 28, 2021
@goern
Copy link
Member

goern commented Jun 28, 2021

/triage accepted
/priority important-soon

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 28, 2021
@goern goern removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 28, 2021
@pacospace
Copy link
Contributor

pacospace commented Jun 29, 2021

Same as #725 (comment) we can see the percentage of failed workflows and the reason, including if it is due to unresolved which is https://thoth-station.ninja/j/unresolved.html if I'm correct? wdyt @fridex ?

@fridex
Copy link
Contributor Author

fridex commented Jun 30, 2021

Same as #725 (comment) we can see the percentage of failed workflows and the reason, including if it is due to unresolved which is https://thoth-station.ninja/j/unresolved.html if I'm correct? wdyt @fridex ?

Nice! Then I think this can be considered as done. 👍🏻

/close

@sesheta
Copy link
Member

sesheta commented Jun 30, 2021

@fridex: Closing this issue.

In response to this:

Same as #725 (comment) we can see the percentage of failed workflows and the reason, including if it is due to unresolved which is https://thoth-station.ninja/j/unresolved.html if I'm correct? wdyt @fridex ?

Nice! Then I think this can be considered as done. 👍🏻

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants