Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider switching to xy interface for kernlab::ksvm() #1115

Open
simonpcouch opened this issue Apr 23, 2024 · 1 comment
Open

consider switching to xy interface for kernlab::ksvm() #1115

simonpcouch opened this issue Apr 23, 2024 · 1 comment
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@simonpcouch
Copy link
Contributor

Related to #1114.

This SO post runs into troubles with the formula interface of kernlab::ksvm() which could be resolved by using the matrix interface of the kernlab function.

We should explore whether there are any potential downsides to switching to kernlab's xy interface and confirm that it resolves the memory protection issues seen in that post.

@clabornd
Copy link

Cant speak to any potential downsides, but fwiw changing svm_poly to use the matrix interface allowed me to run examples that were previously giving me the protection stack overflow error (20K+ features) and have consistent results with the formula interface in examples where both run without error.

Also wondering if directly modifying get_model_env()$svm_poly_fit is a good temporary workaround?

@topepo topepo added tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day feature a feature request or enhancement labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

3 participants