Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing complexity in tune #742

Open
simonpcouch opened this issue Oct 4, 2023 · 2 comments
Open

reducing complexity in tune #742

simonpcouch opened this issue Oct 4, 2023 · 2 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

Much of tune's core internals were written >4yrs ago, before the introduction/maturation of more principled tooling for checking, logging, and erroring from cli and rlang, and before the tidymodels packages that tune extends (parsnip, workflows, recipes) themselves had been developed or matured. Paring away some of tune's internal tooling in favor of that from its dependencies—and some of the complexity that grew organically from tune maturing alongside the tidymodels packages—may make the package more maintainable.

Some areas where I see opportunities:

Logging

Grid code paths

tune_grid_loop_iter() is the layer of the grid code path that, for a given resample, carries out the preprocessor and model fitting.

@simonpcouch simonpcouch pinned this issue Oct 4, 2023
@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Oct 31, 2023
@jrosell

This comment was marked as off-topic.

@simonpcouch
Copy link
Contributor Author

We should be able to make much more headway on the listed issues once we don't have to maintain for some foreach edge cases. While we can start in on some of these now, many will have to wait until the deprecation cycle in #866 is wrapped up, 2 or 3 years out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants