Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in refactored compute_grid_info() #959

Closed
simonpcouch opened this issue Nov 4, 2024 · 0 comments · Fixed by #961
Closed

bug in refactored compute_grid_info() #959

simonpcouch opened this issue Nov 4, 2024 · 0 comments · Fixed by #961
Labels
bug an unexpected problem or unintended behavior

Comments

@simonpcouch
Copy link
Contributor

After merging #957, we saw the following failures on extratests over the weekend:

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure ('test-mars-tuning.R:63:3'): tuning for mars() -- submodels *and* 
mars_metrics$.config (`actual`) not equal to paste0("Preprocessor1_Model", 1:7) (`expected`).

    actual                 | expected                  
[1] "Preprocessor1_Model1" | "Preprocessor1_Model1" [1]
[2] "Preprocessor1_Model1" - "Preprocessor1_Model2" [2]
[3] "Preprocessor1_Model2" - "Preprocessor1_Model3" [3]
[4] "Preprocessor1_Model2" - "Preprocessor1_Model4" [4]
[5] "Preprocessor1_Model3" - "Preprocessor1_Model5" [5]
[6] "Preprocessor1_Model4" - "Preprocessor1_Model6" [6]
[7] "Preprocessor1_Model5" - "Preprocessor1_Model7" [7]

── 2. Failure ('test-mars-tuning.R:68:3'): tuning for mars() -- submodels *and* 
count(mars_preds, .row, .config)$n (`actual`) not equal to rep(1L, 5537) (`expected`).

       actual | expected       
   [4] 1      | 1        [1]   
   [5] 1      | 1        [2]   
   [6] 2      - 1        [3]   
   [7] 2      - 1        [4]   

Some additional trickiness here in grids that are partially regular and partially not so.

@topepo topepo added the bug an unexpected problem or unintended behavior label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
2 participants