-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when combine facet_wrap
with coord_radial
#6360
Comments
It seems we should add following codes before passing the ranges to the ranges <- lapply(ranges, function(range) {
switch(coord$theta,
x = rename(
range,
c(theta.range = "x.range", r.range = "y.range")
),
y = rename(
range,
c(theta.range = "y.range", r.range = "x.range")
)
)
}) But I don't know where is the best place |
Hello. I am new to the package and together with @ChirraneZakariya and under the supervision of @katossky we are willing to solve this issue, as part of an assignment at the ENSAI school of statistical engineering (France). We have read trend figure in readme and we will try to be as autonomous as possible but we may ask for guidance from now and then. We have a solid background in statistics and a reasonable one in computer science. If any maintainer thinks this issue is too ambitious for a beginner, please tell us so and - if you have time - guide us to a project / issue were our help may be more useful. |
We're happy to receive contributions on this issue. The issue doesn't strike me as the most beginner friendly at a first impression, but whether the issue is too ambitious is hard to tell without playing around with it. Of course you're welcome to try! Re @Yunuuuu's proposed solution: that would make sense for Cartesian coordinates, but the panel aspect ratio for polar coordinates is not dependent on the x/y ranges, but on the bounding box around the arc. |
I'm also a little bit unsure what |
Alright, thanks! We'll start working on this shortly, and we're excited to contribute. |
Thanks, @teunbrand I'm working on this feature #6262 based on the implement of After further testing, I found I can still reproduce the figure above even without this argument (Haha, thanks!). @aboudiallo21, I also really appreciate your enthusiasm in tackling this issue! |
@aboudiallo21 I think I found a solution for this issue. Are you still interested in preparing a PR? If you still are, do you want to puzzle around and find a solution yourself or do you want me to suggest a solution I found? |
I found a problem with
facet_wrap
andcoord_radial
Here is the code to reproduce the bug:
Created on 2025-03-13 with reprex v2.1.0
Session info
The text was updated successfully, but these errors were encountered: