Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tigrisdb overwrites system make command after installation #49

Open
piotr-grodek-dsai opened this issue Aug 22, 2023 · 0 comments
Open

Comments

@piotr-grodek-dsai
Copy link

Describe the bug
After installation of tigrisdb in env it installs a make script which is then installed in conda /bin env, leading to unable to correctly use make tool to build thing or run automation tasks in the virtual env.

It also means that any user of tigrisdb won't be able to build&install other python packages if their build system rely on make command in this default setup.

To Reproduce
Steps to reproduce the behavior:

  1. create new conda env
  2. install tigrisdb
  3. See that in conda env bin/ directory there is make script.

It can be also validated (copied from @jedi4ever 's message from langchain issue thread)
pip list | tail -n +3 | cut -d" " -f1 | xargs pip show -f
and then grep for bin/make`:

Name: tigrisdb
Version: 1.0.0b6
Summary: Python SDK for Tigris <http://www.tigrisdata.com>
Home-page: https://www.github.com/tigrisdata/tigris-client-python
Author: Tigris team
Author-email: [email protected]
License: Apache-2.0
Location: /opt/homebrew/anaconda3/envs/langchain-repo/lib/python3.9/site-packages
Requires: grpcio-tools, protobuf
Required-by: 
Files:
  ../../../bin/make
  api/generated/google/api/__pycache__/annotations_pb2.cpython-39.pyc
 (...)

Expected behavior
../../../bin/make should not be installed as part of tigrisdb OR should be installed in a collision-free way.
make should execute command https://linux.die.net/man/1/make

Desktop (please complete the following information):

  • OS: ubuntu
  • Version 22

Additional context
Content of this file:

#!/home/<redacted>/.miniconda3/envs/langchain/bin/python
# -*- coding: utf-8 -*-
import re
import sys
from scripts.proto import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main())

Example issues raised in langchain if you need additional context:
langchain-ai/langchain#6182
langchain-ai/langchain#6915
& more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant