From de6c9d97399fd96c6984a15258fa73dcd7b65104 Mon Sep 17 00:00:00 2001 From: Nick Santos Date: Fri, 16 Sep 2022 17:39:13 -0400 Subject: [PATCH] registry: enable deletion by default (#256) fixes https://github.com/tilt-dev/ctlptl/issues/247 Signed-off-by: Nick Santos --- pkg/registry/registry.go | 1 + pkg/registry/registry_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/registry/registry.go b/pkg/registry/registry.go index 4d50562..c7bdd04 100644 --- a/pkg/registry/registry.go +++ b/pkg/registry/registry.go @@ -253,6 +253,7 @@ func (c *Controller) Apply(ctx context.Context, desired *api.Registry) (*api.Reg Image: desired.Image, ExposedPorts: exposedPorts, Labels: c.labelConfigs(existing, desired), + Env: []string{"REGISTRY_STORAGE_DELETE_ENABLED=true"}, }, &container.HostConfig{ RestartPolicy: container.RestartPolicy{Name: "always"}, diff --git a/pkg/registry/registry_test.go b/pkg/registry/registry_test.go index 333ea34..39d393b 100644 --- a/pkg/registry/registry_test.go +++ b/pkg/registry/registry_test.go @@ -253,6 +253,7 @@ func TestApplyLabels(t *testing.T) { }, config.Labels) assert.Equal(t, "kind-registry", config.Hostname) assert.Equal(t, "docker.io/library/registry:2", config.Image) + assert.Equal(t, []string{"REGISTRY_STORAGE_DELETE_ENABLED=true"}, config.Env) } }