Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more complex comprehensions #302

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

MarcMush
Copy link
Collaborator

fix #58, fix #267, fix #218

allows for comprehensions with conditions and multiple fors

also some refactoring:

  • split showprogress_loop and showprogress_map out of showprogress
  • remove a lot of useless ProgressMeter. in tests

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (807496a) 93.48% compared to head (1ba913a) 96.93%.
Report is 6 commits behind head on master.

Files Patch % Lines
src/ProgressMeter.jl 96.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   93.48%   96.93%   +3.45%     
==========================================
  Files           1        1              
  Lines         399      555     +156     
==========================================
+ Hits          373      538     +165     
+ Misses         26       17       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcMush MarcMush merged commit 7e2bbca into timholy:master Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant