Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use getfield for performance and add performance tests #325

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

MarcMush
Copy link
Collaborator

fix #323

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (807496a) to head (1a2a880).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   93.48%   96.73%   +3.25%     
==========================================
  Files           1        1              
  Lines         399      552     +153     
==========================================
+ Hits          373      534     +161     
+ Misses         26       18       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth
Copy link
Collaborator

Great!

@MarcMush MarcMush merged commit 461c902 into timholy:master Jul 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terrible performance with Julia 1.10+ProgressMeter 1.10
2 participants