Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Readability of Compiled Dataset SQL #30

Open
bcodell opened this issue Mar 29, 2023 · 1 comment
Open

Improve Readability of Compiled Dataset SQL #30

bcodell opened this issue Mar 29, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bcodell
Copy link
Collaborator

bcodell commented Mar 29, 2023

Description

Referencing compiled SQL from the dataset macro is useful for developers on this project who are troubleshooting bugs or new features, as well as for users of the project to inform their understanding of the project's functionality. However, in its current state, the compiled SQL is full of Jinja-inserted line breaks that make reading the compiled SQL especially cumbersome.

This is a low-priority issue, but could also be a good first task to help new contributors get familiarized with the codebase.

Implementation

  • Go through each of the macros and remove whitespace until the compiled SQL is sufficiently readable
@bcodell bcodell added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2023
@janhaviiiiiii7
Copy link

Can I solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcodell @janhaviiiiiii7