Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1847 AE] Fix one private bug and improve the description of another private #11200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[1847 AE] Fix one private bug and improve the description of another private #11200

wants to merge 4 commits into from

Conversation

Galatolol
Copy link
Contributor

@Galatolol Galatolol commented Sep 9, 2024 •
edited by benjaminxscott
Loading

Fixes #11181

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

LFK should pay out only if the train is bought from the supply, not from the discard.
⚠️ This requires pinning.

Rammelsbach's description improved as per #11181.

@ollybh ollybh added pins PR that will require some games to be pinned 1847AE labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollybh ollybh ollybh approved these changes

Assignees
No one assigned
Labels
1847AE pins PR that will require some games to be pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1847AE] indicate Rammelsbach hex can only be laid in phase 5 or later
2 participants
@Galatolol @ollybh