[18Ardennes] Fix error on bankruptcy #11204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra parameter had been added to the G18Ardennes implementation of the `Game.declare_bankrupt` method, which was causing an error when the superclass method was called. This commit renames the 18Ardennes method to `bankrupt!` which calls `declare_bankrupt` with the correct number of parameters. Fixes tobymao#11203.
perwestling
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Notes
An extra parameter had been added to the G18Ardennes implementation of the
Game.declare_bankruptmethod, which was causing an error when the superclass method was called.This commit renames the 18Ardennes method to
bankrupt!which callsdeclare_bankruptwith the correct number of parameters.Fixes #11203.
Before clicking "Create"
masterAdd thepinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake