Best approach to adding WITH [NO] DATA option to CREATE TABLE AS?

[treysp]

Thank you so much for this amazing library!

A few different dialects (Postgres, Tableau, Trino, and some others) support the WITH [NO] DATA option in a CREATE TABLE AS call.

For example:

• CREATE TABLE a AS (SELECT b FROM c) WITH DATA;
• CREATE TABLE a AS (SELECT b FROM c) WITH NO DATA;

I'm wondering about your preferred way to accomplish this. In particular, I'm not sure how the potential use of "data" as a CTE name does (or doesn't) affect the approach.

Overall. it seems like this should be an arg to the Create expression, similar to the temporary or transient args. But it's not clear to me whether it should use a new token type (like temporary) or just match text (like transient).

I have a simple text matching implementation that starts by matching the WITH token then looks at the following text. Is that a reasonable approach? If so, should it be inline in _parse_create or should I create a new parsing function?

[tobymao]

i guess the easiest way is in create table to match the sequence

self._match_text("WITH", "DATA")
self._match_text("WITH", "NO", "DATA")

and add "data": False to the Create expression.

data == None, show nothing
data = False = WITHNO DATA
data = True = WITH DATA