Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning headers in multer::Field #2337

Closed
davidpdrsn opened this issue Nov 23, 2023 · 0 comments · Fixed by #2433
Closed

Avoid cloning headers in multer::Field #2337

davidpdrsn opened this issue Nov 23, 2023 · 0 comments · Fixed by #2433
Labels
A-axum A-axum-extra C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work.

Comments

@davidpdrsn
Copy link
Member

multer still uses http 0.2 which required us to eagerly convert the headers in multer::Field to an http 1.0 HeaderMap.

A PR to update multer to http 1.0 has been merged but not yet published. When its published we can update https://github.com/tokio-rs/axum/blob/main/axum/src/extract/multipart.rs#L98-L103 and https://github.com/tokio-rs/axum/blob/main/axum-extra/src/extract/multipart.rs#L118-L128 to just reuse the headers in the field.
@davidpdrsn davidpdrsn added S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-axum A-axum-extra labels Nov 23, 2023
@davidpdrsn davidpdrsn mentioned this issue Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum A-axum-extra C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update multer tokio-rs/axum
1 participant
@davidpdrsn