We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shutdown_complete_rx
Listner
Why do you put shutdown_complete_rx: mpsc::Receiver<()> into Listner struct if it never used inside of it?
shutdown_complete_rx: mpsc::Receiver<()>
mini-redis/src/server.rs
Line 63 in ebe4e1f
shutdown_complete_tx: mpsc::Sender<()>
The text was updated successfully, but these errors were encountered:
The receiver is used here:
Lines 203 to 207 in ebe4e1f
Sorry, something went wrong.
Remove shutdown_complete_rx from the Listner
1383016
Fix tokio-rs#88 remove unused field from the Listner struct
I see that but why to put it inside of the Listner struct, if you use it only in run function. I made PR with changes that I mean.
run
Successfully merging a pull request may close this issue.
Why do you put
shutdown_complete_rx: mpsc::Receiver<()>
intoListner
struct if it never used inside of it?mini-redis/src/server.rs
Line 63 in ebe4e1f
while
shutdown_complete_tx: mpsc::Sender<()>
seems reasonable for me.The text was updated successfully, but these errors were encountered: