-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: show issue 27 #31
base: main
Are you sure you want to change the base?
Conversation
86728a0
to
6d35a45
Compare
@henryiii you still plan to work on this? |
Yes, been busy with free-threading and other things lately, plus being sick for a few days. Probably later in the week. Don't wait on a release for this, though, as it's just making the formatting nicer after rearranging something that's out of order. I think the nicest idea would be to always preserve whitespace above an element. If the whitespace was "stuck" to the next item, rather than the item before it, I think it would mostly come out nicer. But it take some work to both implement it, test it, and make sure it actually does make it a bit nicer. |
@henryiii ping on this 😊 |
Will try soon! Have conjunctivitis at the moment so not on a computer much. |
Ah, no worries, hope you get better soon! |
@henryiii any updates? |
63c5920
to
009d817
Compare
I've rebased the test, will try my suggested solution by early next week! |
eca71a9
to
b37eb90
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
fd6c825
to
b48069e
Compare
Close #27. Starting with tests.
Not sure why only the Python one fails!Ah,[project]
also has to be present.The problem is that trailing whitespace is attached to the item. So
a\n\n
is moved around as a unit. I think it's tricky to solve nicely for all situations.I think what makes sense is to preserve space around headings. So the only part given to the reorder is the chunk that starts with a non-space and ends with an entry.
(I'm referring to the part before running the normal run that limits spaces to one line, etc)