Consider complete envs, not factors #3220
Conversation
To determine whether we have been given a valid *env*, we compare the *factors* of the *env* to our known set of *factors*. If a testenv contains a series of valid factors, we assume the testenv is valid. This is an incorrect assumption: a testenv is only valid if it defined in the configuration file *or* is one of the "special" auto-generated testenvs like e.g. 'py310'. Correct this mistake. While we're here, we make use of verbose mode to explain our regex for matching "magic" factors better. Signed-off-by: Stephen Finucane <[email protected]> Closes: tox-dev#3219
stephenfin
force-pushed
the
issues/3219
branch
from
8e99154
to
9b0529c
Compare
|
This is currently failing a few tests because it does not allow for autogenerated testenvs based on factors defined in e.g. [testenv]
commands =
foo: echo "got foo"
bar: echo "got bar"That this worked suprised me: I'd normally have defined this in my [testenv:py{310,311,312}{,-cov}]but that is definitely duplication. I can work to fix this but again, I want to confirm that the bug I'm seeing is indeed a bug (it really feels like one) |
|
Converting to non-draft, even though it's clearly not complete, so that folks see it. |
We see, without it too, was waiting for you to pass the CI.
I'd say, in general, yes. But note, I want to allow |
|
Closing as seems it stalled, we can reopen if you get time again for it. |
To determine whether we have been given a valid env, we compare the factors of the env to our known set of factors. If a testenv contains a series of valid factors, we assume the testenv is valid. This is an incorrect assumption: a testenv is only valid if it defined in the configuration file or is one of the "special" auto-generated testenvs like e.g. 'py310'. Correct this mistake.
This is a draft PR while I wait for feedback on my general idea here. I'd like to confirm that my understanding of expected behavior is correct.
Signed-off-by: Stephen Finucane [email protected]
Closes: #3219
tox -e fix)docs/changelogfolder