Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codesign issue with files with space #122

Open
etrinh opened this issue Jun 21, 2022 · 1 comment
Open

codesign issue with files with space #122

etrinh opened this issue Jun 21, 2022 · 1 comment

Comments

@etrinh
Copy link

etrinh commented Jun 21, 2022

Hi,

Thank you very much for the sigtool addition!
Just a small remark, it fails to sign files with spaces.

In file /cctools/include/stuff/port.h
On line 60:
snprintf(codesign_command, sizeof(codesign_command), "%s -s - -f %s", codesign, filename);
Can be replaced with something like (quotes added):
snprintf(codesign_command, sizeof(codesign_command), "%s -s - -f '%s'", codesign, filename); \

@tpoechtrager
Copy link
Owner

Hi,
thanks for the hint. I think it should be replaced by execvp or something similar to get rid of the issue. Adding quotes doesn't fix the issue entirely. The entire macro needs some rework. There seem to be some obvious bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants