chore(engine): Simplify compile_class_static_field (#597)

Author: aapoalas

nova_vm/src/engine/bytecode/bytecode_compiler.rs

@@ -106,23 +106,10 @@ impl<'a, 'gc, 'scope> CompileContext<'a, 'gc, 'scope> {
     /// current context.
     pub(crate) fn compile_class_static_field(
         &mut self,
-        property_key: &ast::PropertyKey<'_>,
-        value: &Option<ast::Expression<'_>>,
+        identifier_name: &ast::IdentifierName,
+        value: &Option<ast::Expression>,
     ) {
-        let identifier = match property_key {
-            ast::PropertyKey::StaticIdentifier(identifier_name) => {
-                String::from_str(self.agent, identifier_name.name.as_str(), self.gc)
-            }
-            ast::PropertyKey::PrivateIdentifier(_private_identifier) => todo!(),
-            ast::PropertyKey::BooleanLiteral(_boolean_literal) => todo!(),
-            ast::PropertyKey::NullLiteral(_null_literal) => todo!(),
-            ast::PropertyKey::NumericLiteral(_numeric_literal) => todo!(),
-            ast::PropertyKey::BigIntLiteral(_big_int_literal) => todo!(),
-            ast::PropertyKey::RegExpLiteral(_reg_exp_literal) => todo!(),
-            ast::PropertyKey::StringLiteral(_string_literal) => todo!(),
-            ast::PropertyKey::TemplateLiteral(_template_literal) => todo!(),
-            _ => unreachable!(),
-        };
+        let identifier = String::from_str(self.agent, identifier_name.name.as_str(), self.gc);
         // Turn the static name to a 'this' property access.
         self.add_instruction(Instruction::ResolveThisBinding);
         self.add_instruction_with_identifier(
@@ -2267,16 +2254,6 @@ impl CompileEvaluation for ast::VariableDeclaration<'_> {
     }
 }
 
-impl CompileEvaluation for ast::Declaration<'_> {
-    fn compile(&self, ctx: &mut CompileContext) {
-        match self {
-            ast::Declaration::VariableDeclaration(x) => x.compile(ctx),
-            ast::Declaration::FunctionDeclaration(x) => x.compile(ctx),
-            other => todo!("{other:?}"),
-        }
-    }
-}
-
 impl CompileEvaluation for ast::BlockStatement<'_> {
     fn compile(&self, ctx: &mut CompileContext) {
         if self.body.is_empty() {

nova_vm/src/engine/bytecode/bytecode_compiler/class_definition_evaluation.rs

@@ -372,8 +372,12 @@ impl CompileEvaluation for ast::Class<'_> {
                             &property_definition.value,
                         );
                     } else {
+                        let ast::PropertyKey::StaticIdentifier(key) = &property_definition.key
+                        else {
+                            unreachable!()
+                        };
                         instance_fields.push(PropertyInitializerField::Static((
-                            &property_definition.key,
+                            key,
                             &property_definition.value,
                         )));
                     }
@@ -521,7 +525,7 @@ impl CompileEvaluation for ast::Class<'_> {
 
 #[derive(Debug)]
 enum PropertyInitializerField<'a, 'gc> {
-    Static((&'a ast::PropertyKey<'a>, &'a Option<ast::Expression<'a>>)),
+    Static((&'a ast::IdentifierName<'a>, &'a Option<ast::Expression<'a>>)),
     Computed((String<'gc>, &'a Option<ast::Expression<'a>>)),
 }