From dee8c6c62f6ecd9647806b7ca11b39f20d3d8333 Mon Sep 17 00:00:00 2001 From: Karl Prokupek Date: Thu, 20 Feb 2025 16:07:36 +0100 Subject: [PATCH] Fix Linux build command in README.md because PhotinoDialog was not compiled. --- README.md | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 095bbb6..e16c2e0 100644 --- a/README.md +++ b/README.md @@ -28,6 +28,19 @@ The GitHub repository includes .yml files for automated CI/CD builds, packaging * Windows - Open the solution in Visual Studio 2019 or later with the **Desktop development with C++** workload installed. The **Linux development with C++** workload is recommended, but not required. You *must* build in x64 configuration (*not* AnyCPU which is the default). You *must* install either the [WebView2 runtime]( https://go.microsoft.com/fwlink/p/?LinkId=2124703 ) or the [Edge Dev Channel]( https://www.microsoftedgeinsider.com/en-us/download ). Beta and Canary should work as well, but that hasn't been verified. Just having Edge Chromium installed will not work. The project will build, but will not work properly in a development environment. -* Linux - (Tested with Ubuntu 18.04 and 20.04) Install dependencies: `sudo apt-get update && sudo apt-get install libgtk-3-dev libwebkit2gtk-4.0-dev libnotify-dev`. To compile, run `gcc -std=c++11 -shared -DOS_LINUX Exports.cpp Photino.Linux.cpp -o x64/$(buildConfiguration)/Photino.Native.so 'pkg-config --cflags --libs gtk+-3.0 webkit2gtk-4.0 libnotify' -fPIC` +* Linux - (Tested with Ubuntu 18.04 and 20.04) Install dependencies: + ``` + sudo apt-get update && sudo apt-get install libgtk-3-dev libwebkit2gtk-4.0-dev libnotify-dev + ``` + + To compile, replace $(buildConfiguration) with `Release` and run + ``` + gcc -std=c++11 -shared -DOS_LINUX Exports.cpp Photino.Linux.cpp Photino.Linux.Dialog.cpp -o x64/$(buildConfiguration)/Photino.Native.so `pkg-config --cflags --libs gtk+-3.0 webkit2gtk-4.0 libnotify` -fPIC + ``` -* Mac - Install Xcode. To compile, run `gcc -shared -lstdc++ -DOS_MAC -framework Cocoa -framework WebKit Photino.Mac.mm Exports.cpp Photino.Mac.AppDelegate.mm Photino.Mac.UiDelegate.mm Photino.Mac.UrlSchemeHandler.mm -o x64/$(buildConfiguration)/Photino.Native.dylib`. +* Mac - Install Xcode. + + To compile, replace $(buildConfiguration) with `Release` and run + ``` + gcc -shared -lstdc++ -DOS_MAC -framework Cocoa -framework WebKit Photino.Mac.mm Exports.cpp Photino.Mac.AppDelegate.mm Photino.Mac.UiDelegate.mm Photino.Mac.UrlSchemeHandler.mm -o x64/$(buildConfiguration)/Photino.Native.dylib + ```